iwlwifi: pcie: don't swallow error codes in iwl_trans_pcie_alloc()

Browse source

The iwl_trans_pcie_alloc() function doesn't pass up error codes
returned from functions it calls, swallowing them and returning NULL
in all failure cases.  The caller checks if the return value is NULL
and returns -ENOMEM.  This is not correct, because in certain cases
the failure was not due to an OOM situation.

To fix this, modify the iwl_trans_pcie_alloc() function to use
ERR_PTR() to return error codes and clean up the error handling code
a bit.

Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

...

This commit is contained in:

Luciano Coelho 2013-08-10 16:35:45 +03:00 • committed by Johannes Berg

parent f8f03c3edc

commit 6965a3540a

2 changed files with 17 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/wireless/iwlwifi/pcie/drv.c

View file

26

drivers/net/wireless/iwlwifi/pcie/trans.c

View file