drm/i915: Make closing request flush mandatory

Browse source

For symmetry, simplicity and ensuring the request is always truly idle
upon its completion, always emit the closing flush prior to emitting the
request breadcrumb. Previously, we would only emit the flush if we had
started a user batch, but this just leaves all the other paths open to
speculation (do they affect the GPU caches or not?) With mm switching, a
key requirement is that the GPU is flushed and invalidated before hand,
so for absolute safety, we want that closing flush be mandatory.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180612105135.4459-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2018-06-12 11:51:35 +01:00

parent e4dd27aadd

commit 697b9a8714

12 changed files with 24 additions and 47 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/i915/i915_gem.c

View file

9

drivers/gpu/drm/i915/i915_gem_context.c

View file

4

drivers/gpu/drm/i915/i915_gem_execbuffer.c

View file

18

drivers/gpu/drm/i915/i915_request.c

View file

4

drivers/gpu/drm/i915/i915_request.h

View file

2

drivers/gpu/drm/i915/selftests/huge_pages.c

View file

4

drivers/gpu/drm/i915/selftests/i915_gem_coherency.c

View file

4

drivers/gpu/drm/i915/selftests/i915_gem_context.c

View file

2

drivers/gpu/drm/i915/selftests/i915_request.c

View file

16

drivers/gpu/drm/i915/selftests/intel_hangcheck.c

View file

2

drivers/gpu/drm/i915/selftests/intel_lrc.c

View file

2

drivers/gpu/drm/i915/selftests/intel_workarounds.c

View file