net/mlx5e: Fix possible non-initialized struct usage

Browse source

If mlx5e_devlink_port_register() fails, driver may try to register
devlink health TX and RX reporters on non-registered devlink port.

Instead, create health reporters only if mlx5e_devlink_port_register()
does not fail. And destroy reporters only if devlink_port is registered.

Also, change mlx5e_get_devlink_port() behavior and return NULL in case
port is not registered to replicate devlink's wrapper when ndo is not
implemented.

Signed-off-by: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

...

This commit is contained in:

Vladyslav Tarasiuk 2021-04-13 11:15:49 +03:00 • committed by Saeed Mahameed

parent d408c01cae

commit 6a5689ba02

2 changed files with 15 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c

View file

10

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

View file