drm/rockchip: vop: clear DMA stop bit on RK3066

Browse source

The RK3066 VOP sets a dma_stop bit when it's done scanning out a frame
and needs the driver to acknowledge that by clearing the bit.

Unless we clear it "between" frames, the RGB output only shows noise
instead of the picture. atomic_flush is the place for it that least
affects other code (doing it on vblank would require converting all
other usages of the reg_lock to spin_(un)lock_irq, which would affect
performance for everyone).

This seems to be a redundant synchronization mechanism that was removed
in later iterations of the VOP hardware block.

Fixes: f4a6de855e ("drm: rockchip: vop: add rk3066 vop definitions")
Cc: stable@vger.kernel.org
Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240624204054.5524-2-val@packett.cool

...

This commit is contained in:

Val Packett 2024-06-24 17:40:48 -03:00 • committed by Heiko Stuebner

parent ab03974df2

commit 6b44aa559d

3 changed files with 6 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/rockchip/rockchip_drm_vop.c

View file

1

drivers/gpu/drm/rockchip/rockchip_drm_vop.h

View file

1

drivers/gpu/drm/rockchip/rockchip_vop_reg.c

View file