staging: rtl8188eu: Simplify memcmp logical checks

Browse source

Clang generates a warning when it sees a logical not followed by a
conditional operator like ==, >, or < because it thinks that the logical
not should be applied to the whole statement:

drivers/staging/rtl8188eu/core/rtw_ieee80211.c:293:8: warning: logical
not is only applied to the left hand side of this comparison
[-Wlogical-not-parentheses]

It assumes the author might have made a mistake in their logic:

if (!a == b) -> if (!(a == b))

Sometimes that is the case; other times, it's just a super convoluted
way of saying 'if (a)' when b = 0:

if (!1 == 0) -> if (0 == 0) -> if (true)

Alternatively:

if (!1 == 0) -> if (!!1) -> if (1)

Simplify these comparisons so that Clang doesn't complain.

Link: https://github.com/ClangBuiltLinux/linux/issues/161
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Nathan Chancellor 2018-09-25 12:13:26 -07:00 • committed by Greg Kroah-Hartman

parent 9f902b495b

commit 6b9e49b25e

4 changed files with 5 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/staging/rtl8188eu/core/rtw_ieee80211.c

View file

2

drivers/staging/rtl8188eu/core/rtw_mlme.c

View file

4

drivers/staging/rtl8188eu/core/rtw_recv.c

View file

2

drivers/staging/rtl8188eu/core/rtw_wlan_util.c

View file