staging: rtl8723bs: os_dep: Replace sprintf with scnprintf

Browse source

The use of sprintf with format string here means that there is a risk
that the writes will go out of bounds, replace it with scnprintf.

In one block of the translate_scan function sprintf is only called once
(it's not being used to concatenate strings) so there is no need to keep
the pointer "p", remove it.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Candy Febriyanto <cfebriyanto@gmail.com>
Link: https://lore.kernel.org/r/d76c5f1db8dbf02ac0ab954b0971ce24e5a8b9bd.1614610197.git.cfebriyanto@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Candy Febriyanto 2021-03-01 22:00:11 +07:00 • committed by Greg Kroah-Hartman

parent 2a02059e4f

commit 6d108d064c

2 changed files with 14 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

23

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

View file

6

drivers/staging/rtl8723bs/os_dep/mlme_linux.c

View file