rtw88: avoid holding mutex for cancel_delayed_work_sync()

Browse source

Driver could possibly be dead-locked while canceling works with
*_sync() with mutex lock held. Those cancel_delayed_work_sync()
functions will wait until the work is done, but if we hold the
lock, they will never acquire the lock.

To prevent this, simply release the lock and acquire again after
the works have been canceled. And to avoid the works being queued
again, check if the device is at RTW_FLAG_RUNNING state, otherwise
just return and do nothing.

Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

...

This commit is contained in:

Yan-Hsuan Chuang 2020-02-05 15:08:56 +08:00 • committed by Kalle Valo

parent 398b9bdab2

commit 6eab0ba99b

3 changed files with 12 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/net/wireless/realtek/rtw88/coex.c

View file

4

drivers/net/wireless/realtek/rtw88/fw.c

View file

5

drivers/net/wireless/realtek/rtw88/main.c

View file