drm/msm: Fix debugfs deadlock

Browse source

In normal cases the gem obj lock is acquired first before mm_lock.  The
exception is iterating the various object lists.  In the shrinker path,
deadlock is avoided by using msm_gem_trylock() and skipping over objects
that cannot be locked.  But for debugfs the straightforward thing is to
split things out into a separate list of all objects protected by it's
own lock.

Fixes: d984457b31 ("drm/msm: Add priv->mm_lock to protect active/inactive lists")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20210401012722.527712-4-robdclark@gmail.com
Signed-off-by: Rob Clark <robdclark@chromium.org>

...

This commit is contained in:

Rob Clark 2021-03-31 18:27:20 -07:00

parent cc8a4d5a1b

commit 6ed0897cd8

5 changed files with 35 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/gpu/drm/msm/msm_debugfs.c

View file

3

drivers/gpu/drm/msm/msm_drv.c

View file

9

drivers/gpu/drm/msm/msm_drv.h

View file

14

drivers/gpu/drm/msm/msm_gem.c

View file

10

drivers/gpu/drm/msm/msm_gem.h

View file