nfsd4: Move callback setup to callback queue

Browse source

Instead of creating the new rpc client from a regular server thread,
set a flag, kick off a null call, and allow the null call to do the work
of setting up the client on the callback workqueue.

Use a spinlock to ensure the callback work gets a consistent view of the
callback parameters.

This allows, for example, changing the callback from contexts where
sleeping is not allowed.  I hope it will also keep the locking simple as
we add more session and trunking features, by serializing most of the
callback-specific work.

This also closes a small race where the the new cb_ident could be used
with an old connection (or vice-versa).

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

...

This commit is contained in:

J. Bruce Fields 2010-06-04 20:04:45 -04:00 • committed by J. Bruce Fields

parent fb00392326

commit 6ff8da0887

3 changed files with 63 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

73

fs/nfsd/nfs4callback.c

View file

7

fs/nfsd/nfs4state.c

View file

10

fs/nfsd/state.h

View file