[PATCH] char/tpm: use msleep(), clean-up timers,

Browse source

The TPM driver unnecessarily uses timers when it simply needs to maintain a
maximum delay via time_before().  msleep() is used instead of
schedule_timeout() to guarantee the task delays as expected.  While
compile-testing, I found a typo in the driver, using tpm_chp instead of
tpm_chip.  Remove the now unused timer callback function and change
TPM_TIMEOUT's units to milliseconds.  Patch is compile-tested.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Kylene Hall <kjhall@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

...

This commit is contained in:

Nishanth Aravamudan 2005-06-23 22:01:47 -07:00 • committed by Linus Torvalds

parent 6a94f92097

commit 700d8bdcd0

3 changed files with 18 additions and 52 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

drivers/char/tpm/tpm.c

View file

3

drivers/char/tpm/tpm.h

View file

32

drivers/char/tpm/tpm_nsc.c

View file