NFSD: Hoist rq_vec preparation into nfsd_read() [step two]

Browse source

Now that the preparation of an rq_vec has been removed from the
generic read path, nfsd_splice_read() no longer needs to reset
rq_next_page.

nfsd4_encode_read() calls nfsd_splice_read() directly. As far as I
can ascertain, resetting rq_next_page for NFSv4 splice reads is
unnecessary because rq_next_page is already set correctly.

Moreover, resetting it might even be incorrect if previous
operations in the COMPOUND have already consumed at least a page of
the send buffer. I would expect that the result would be encoding
the READ payload over previously-encoded results.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

...

This commit is contained in:

Chuck Lever 2023-05-18 13:46:03 -04:00

parent 507df40ebf

commit 703d752155

4 changed files with 30 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

fs/nfsd/nfs4xdr.c

View file

13

fs/nfsd/vfs.c

View file

3

include/linux/sunrpc/xdr.h

View file

26

net/sunrpc/xdr.c

View file