svcrdma: Clean up svc_rdma_build_read_chunk()

Browse source

Dan Carpenter <dan.carpenter@oracle.com> observed that the while()
loop in svc_rdma_build_read_chunk() does not document the assumption
that the loop interior is always executed at least once.

Defensive: the function now returns -EINVAL if this assumption
fails.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Chuck Lever 2017-08-01 12:00:14 -04:00 • committed by J. Bruce Fields

parent afea5657c2

commit 7075a867ce

1 changed files with 5 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

net/sunrpc/xprtrdma/svc_rdma_rw.c

View file