IB/ipath: Use counters in ipath_poll and cleanup interrupts in ipath_close

Browse source

ipath_poll() suffered from a couple subtle bugs.  Under the right
conditions we could leave recv interrupts enabled on an ipath user
context on close, thereby taking potentially unwanted interrupts on the
next open -- this is fixed by unconditionally turning off recv
interrupts on close.  Also, we now use counters rather than set/clear
bits which allows us to make sure we catch all interrupts at the cost of
changing the semantics slightly (it's now give me all events since the
last time I called poll() rather than give me all events since I called
_this_ poll routine).  We also added some memory barriers which may help
ensure we get all notifications in a timely manner.

Signed-off-by: Arthur Jones <arthur.jones@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

...

This commit is contained in:

Arthur Jones 2007-09-14 12:22:49 -07:00 • committed by Roland Dreier

parent 542869a17e

commit 70c51da2c4

3 changed files with 57 additions and 51 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

67

drivers/infiniband/hw/ipath/ipath_file_ops.c

View file

33

drivers/infiniband/hw/ipath/ipath_intr.c

View file

8

drivers/infiniband/hw/ipath/ipath_kernel.h

View file