crypto: nx - Fixing SHA update bug

Browse source

commit 10d87b730e upstream.

Bug happens when a data size less than SHA block size is passed.
Since first attempt will be saved in buffer, second round attempt
get into two step to calculate op.inlen and op.outlen. The issue
resides in this step. A  wrong value of op.inlen and outlen was being
calculated.

This patch fix this eliminate the nx_sha_build_sg_list, that is
useless in SHA's algorithm context. Instead we call nx_build_sg_list
directly and pass a previous calculated max_sg_len to it.

Signed-off-by: Leonidas S. Barbosa <leosilva@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Leonidas Da Silva Barbosa 2015-04-23 17:41:43 -03:00 • committed by Greg Kroah-Hartman

parent b2b6e1667f

commit 71a0c1ecf7

4 changed files with 99 additions and 119 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

86

drivers/crypto/nx/nx-sha256.c

View file

87

drivers/crypto/nx/nx-sha512.c

View file

47

drivers/crypto/nx/nx.c

View file

2

drivers/crypto/nx/nx.h

View file