attr: add setattr_should_drop_sgid()

Browse source

The current setgid stripping logic during write and ownership change
operations is inconsistent and strewn over multiple places. In order to
consolidate it and make more consistent we'll add a new helper
setattr_should_drop_sgid(). The function retains the old behavior where
we remove the S_ISGID bit unconditionally when S_IXGRP is set but also
when it isn't set and the caller is neither in the group of the inode
nor privileged over the inode.

We will use this helper both in write operation permission removal such
as file_remove_privs() as well as in ownership change operations.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>

...

This commit is contained in:

Christian Brauner 2022-10-17 17:06:36 +02:00 • committed by Christian Brauner (Microsoft)

parent e243e3f94c

commit 72ae017c54

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

2 changed files with 34 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

fs/attr.c

View file

6

fs/internal.h

View file