xfs: refactor inode ownership change transaction/inode/quota allocation idiom

Browse source

For file ownership (uid, gid, prid) changes, create a new helper
xfs_trans_alloc_ichange that allocates a transaction and reserves the
appropriate amount of quota against that transction in preparation for a
change of user, group, or project id.  Replace all the open-coded idioms
with a single call to this helper so that we can contain the retry loops
in the next patchset.

This changes the locking behavior for ichange transactions slightly.
Since tr_ichange does not have a permanent reservation and cannot roll,
we pass XFS_ILOCK_EXCL to ijoin so that the inode will be unlocked
automatically at commit time.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>

...

This commit is contained in:

Darrick J. Wong 2021-01-29 11:32:09 -08:00

parent f2f7b9ff62

commit 7317a03df7

4 changed files with 77 additions and 43 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

fs/xfs/xfs_ioctl.c

View file

26

fs/xfs/xfs_iops.c

View file

62

fs/xfs/xfs_trans.c

View file

3

fs/xfs/xfs_trans.h

View file