mac80211: split sta_info_add

Browse source

sta_info_add() has two functions: allocating a station info
structure and inserting it into the hash table/list. Splitting
these two functions allows allocating with GFP_KERNEL in many
places instead of GFP_ATOMIC which is now required by the RCU
protection. Additionally, in many places RCU protection is now
no longer needed at all because between sta_info_alloc() and
sta_info_insert() the caller owns the structure.

This fixes a few race conditions with setting initial flags
and similar, but not all (see comments in ieee80211_sta.c and
cfg.c). More documentation on the existing races will be in
a follow-up patch.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Johannes Berg 2008-02-25 16:27:47 +01:00 • committed by John W. Linville

parent d0709a6518

commit 73651ee639

7 changed files with 166 additions and 74 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

42

net/mac80211/cfg.c

View file

18

net/mac80211/ieee80211.c

View file

44

net/mac80211/ieee80211_sta.c

View file

4

net/mac80211/mesh.h

View file

43

net/mac80211/mesh_plink.c

View file

72

net/mac80211/sta_info.c

View file

17

net/mac80211/sta_info.h

View file