ASoC: rt5663: Fix error handling of regulator_set_load

Browse source

The default implementation of regulator_set_load returns
REGULATOR_MODE_NORMAL, which is positive.  [This was a bug which is
being fixed but the change is valid anyway -- bronie]

rt5663_i2c_probe should only do error handling when return value of
regulator_set_load is negative.
In this case, rt5663_i2c_probe should return error.

Also, consolidate err_irq into err_enable.

Fix the missing goto for temporary regmap and rt5663->regmap.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Cheng-Yi Chiang 2018-11-16 17:28:56 +08:00 • committed by Mark Brown

parent 00347e4ea8

commit 746dca0aeb

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 12 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

sound/soc/codecs/rt5663.c

View file