drm/v3d: Fix potential memory leak in the timestamp extension

Browse source

If fetching of userspace memory fails during the main loop, all drm sync
objs looked up until that point will be leaked because of the missing
drm_syncobj_put.

Fix it by exporting and using a common cleanup helper.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fixes: 9ba0ff3e08 ("drm/v3d: Create a CPU job extension for the timestamp query job")
Cc: Maíra Canal <mcanal@igalia.com>
Cc: Iago Toral Quiroga <itoral@igalia.com>
Cc: stable@vger.kernel.org # v6.8+
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240711135340.84617-3-tursulin@igalia.com

...

This commit is contained in:

Tvrtko Ursulin 2024-07-11 14:53:31 +01:00 • committed by Maíra Canal

parent f32b5128d2

commit 753ce4fea6

No known key found for this signature in database

GPG key ID: 6E388F05AB35B7CF

3 changed files with 48 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/gpu/drm/v3d/v3d_drv.h

View file

22

drivers/gpu/drm/v3d/v3d_sched.c

View file

43

drivers/gpu/drm/v3d/v3d_submit.c

View file