spi: npcm: fix u32 csgpio being checked for less than zero

Browse source

The u32 variable csgpio is being checked for an error return
from the call to of_get_named_gpio, however, since this is unsigned
this comparison will always be false. Fix this by making csgpio an
int and fix up the %u format specifiers to %d accordingly.

Detected by CoverityScan, CID#1475476 ("Unsigned compared against 0")

Fixes: 2a22f1b30c ("spi: npcm: add NPCM PSPI controller driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Colin Ian King 2018-11-14 21:42:46 +00:00 • committed by Mark Brown

parent 2a22f1b30c

commit 757ec116c9

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 3 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/spi/spi-npcm-pspi.c

View file