net/mlx5: Fix use after free in mlx5_health_wait_pci_up

Browse source

The device health recovery flow calls mlx5_health_wait_pci_up() which
queries the device for FW_RESET timeout after freeing the device
timeouts structure on mlx5_function_teardown(). Fix this bug by moving
timeouts structure init/cleanup to the device's init/uninit phases.
Since it is necessary to reset default software timeouts on function
reload, extract setting of defaults values from mlx5_tout_init() and
call mlx5_tout_set_def_val() directly from mlx5_function_setup().

Fixes: 5945e1adea ("net/mlx5: Read timeout values from init segment")
Reported by: Niklas Schnelle <schnelle@linux.ibm.com>
Signed-off-by: Amir Tzin <amirtz@nvidia.com>
Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

...

This commit is contained in:

Amir Tzin 2021-10-20 12:45:05 +03:00 • committed by Saeed Mahameed

parent e219440da0

commit 76091b0fb6

3 changed files with 15 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/ethernet/mellanox/mlx5/core/lib/tout.c

View file

1

drivers/net/ethernet/mellanox/mlx5/core/lib/tout.h

View file

22

drivers/net/ethernet/mellanox/mlx5/core/main.c

View file