ovl: simplify gotos in ovl_rename()

Browse source

Rather than having three separate goto label: out_unlock, out_dput_old,
and out_dput, make use of that fact that dput() happily accepts a NULL
pointer to reduce this to just one goto label: out_unlock.

olddentry and newdentry are initialised to NULL and only set once a
value dentry is found.  They are then dput() late in the function.

Suggested-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: NeilBrown <neil@brown.name>
Link: https://lore.kernel.org/20250716004725.1206467-9-neil@brown.name
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

NeilBrown 2025-07-16 10:44:19 +10:00 • committed by Christian Brauner

parent e460bc4d01

commit 76342c9eb8

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 27 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

54

fs/overlayfs/dir.c

View file