SUNRPC: Move fault injection call sites

Browse source

I've hit some crashes that occur in the xprt_rdma_inject_disconnect
path. It appears that, for some provides, rdma_disconnect() can
take so long that the transport can disconnect and release its
hardware resources while rdma_disconnect() is still running,
resulting in a UAF in the provider.

The transport's fault injection method may depend on the stability
of transport data structures. That means it needs to be invoked
only from contexts that hold the transport write lock.

Fixes: 4a06825839 ("SUNRPC: Transport fault injection")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

...

This commit is contained in:

Chuck Lever 2021-03-31 13:22:14 -04:00 • committed by Trond Myklebust

parent 73f5c88f52

commit 7638e0bfae

3 changed files with 8 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

net/sunrpc/clnt.c

View file

6

net/sunrpc/xprt.c

View file

6

net/sunrpc/xprtrdma/transport.c

View file