x86: fix trim mtrr not to setup_memory two times

Browse source

we could call find_max_pfn() directly instead of setup_memory() to get
max_pfn needed for mtrr trimming.

otherwise setup_memory() is called two times... that is duplicated...

[ mingo@elte.hu: both Thomas and me simulated a double call to
  setup_bootmem_allocator() and can confirm that it is a real bug
  which can hang in certain configs. It's not been reported yet but
  that is probably due to the relatively scarce nature of
  MTRR-trimming systems. ]

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

...

This commit is contained in:

Yinghai Lu 2008-03-23 00:16:49 -07:00 • committed by Ingo Molnar

parent 923a0cf82f

commit 76c324182b

2 changed files with 4 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

arch/x86/kernel/setup_32.c

View file

1

arch/x86/mm/discontig_32.c

View file