afs: Fix afs_xattr_get_yfs() to not try freeing an error value

Browse source

afs_xattr_get_yfs() tries to free yacl, which may hold an error value (say
if yfs_fs_fetch_opaque_acl() failed and returned an error).

Fix this by allocating yacl up front (since it's a fixed-length struct,
unlike afs_acl) and passing it in to the RPC function.  This also allows
the flags to be placed in the object rather than passing them through to
the RPC function.

Fixes: ae46578b96 ("afs: Get YFS ACLs and information through xattrs")
Signed-off-by: David Howells <dhowells@redhat.com>

...

This commit is contained in:

David Howells 2019-05-12 08:31:23 +01:00

parent cc1dd5c85c

commit 773e0c4025

3 changed files with 53 additions and 64 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/afs/internal.h

View file

88

fs/afs/xattr.c

View file

29

fs/afs/yfsclient.c

View file