net: axienet: Re-initialize MDIO registers properly after reset

Browse source

The MDIO clock divisor register setting was only applied on the initial
startup when the driver was loaded. However, this setting is cleared
when the device is reset, such as would occur when the interface was
taken down and brought up again, and so the MDIO bus would be
non-functional afterwards.

Split up the MDIO bus setup and enable into separate functions and
re-enable the bus after a device reset, to ensure that the MDIO
registers are set properly. This also allows us to remove direct access
to MDIO registers in xilinx_axienet_main.c and centralize them all in
xilinx_axienet_mdio.c.

Also, lock the MDIO bus lock around the device reset process, to avoid
MDIO accesses from occurring while the MDIO is disabled during the reset.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Robert Hancock 2019-06-06 16:28:11 -06:00 • committed by David S. Miller

parent e7a3d116fa

commit 7789e9ed05

3 changed files with 57 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/net/ethernet/xilinx/xilinx_axienet.h

View file

38

drivers/net/ethernet/xilinx/xilinx_axienet_main.c

View file

54

drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c

View file