greybus: clean up gb_connection_operation_recv()

Browse source

This patch does some cleanup of gb_connection_operation_recv().
    - Improve the header comments
    - Verify message is big enough for header before interpreting
      beginning of the message as a header
    - Verify at buffer creation time rather than receive time that
      no operation buffer is bigger than the maximum allowed.  We
      can then compare the incoming data size against the buffer.
    - When a response message arrives, record its status in the
      operation result, not in the buffer status.
    - Record a buffer overflow as an operation error.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

...

This commit is contained in:

Alex Elder 2014-11-17 08:08:39 -06:00 • committed by Greg Kroah-Hartman

parent b37716f672

commit 78496db012

2 changed files with 20 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

drivers/staging/greybus/operation.c

View file

1

drivers/staging/greybus/operation.h

View file