RDMA/rxe: Remove tasklet call from rxe_cq.c

Browse source

Remove the tasklet call in rxe_cq.c and also the is_dying in the
cq struct. There is no reason for the rxe driver to defer the call
to the cq completion handler by scheduling a tasklet. rxe_cq_post()
is not called in a hard irq context.

The rxe driver currently is incorrect because the tasklet call is
made without protecting the cq pointer with a reference from having
the underlying memory freed before the deferred routine is called.
Executing the comp_handler inline fixes this problem.

Fixes: 8700e3e7c4 ("Soft RoCE driver")
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Link: https://lore.kernel.org/r/20230327215643.10410-1-rpearsonhpe@gmail.com
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>

...

This commit is contained in:

Bob Pearson 2023-03-27 16:56:44 -05:00 • committed by Leon Romanovsky

parent cba968e33e

commit 78b26a3353

3 changed files with 3 additions and 33 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/infiniband/sw/rxe/rxe_cq.c

View file

2

drivers/infiniband/sw/rxe/rxe_verbs.c

View file

2

drivers/infiniband/sw/rxe/rxe_verbs.h

View file