docs: kernel_abi.py: fix command injection

Browse source

commit 3231dd5862 upstream.

The kernel-abi directive passes its argument straight to the shell.
This is unfortunate and unnecessary.

Let's always use paths relative to $srctree/Documentation/ and use
subprocess.check_call() instead of subprocess.Popen(shell=True).

This also makes the code shorter.

Link: https://fosstodon.org/@jani/111676532203641247
Reported-by: Jani Nikula <jani.nikula@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20231231235959.3342928-2-vegard.nossum@oracle.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Vegard Nossum 2024-01-01 00:59:59 +01:00 • committed by Greg Kroah-Hartman

parent 4ecf1864f2

commit 78d757c607

5 changed files with 14 additions and 50 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

Documentation/admin-guide/abi-obsolete.rst

View file

2

Documentation/admin-guide/abi-removed.rst

View file

2

Documentation/admin-guide/abi-stable.rst

View file

2

Documentation/admin-guide/abi-testing.rst

View file

56

Documentation/sphinx/kernel_abi.py

View file