drm/msm/mdp5: Use the new private_obj state

Browse source

This replaces the usage of the subclassed atomic state (mdp5_state)
with a private_obj state embedded within drm_atomic_state. The latter
method is the preferred approach, since it's simpler to implement
and less prone to errors.

The new API replaces the older and equivalent mdp5_state usage in the
following pattern:
- References to "mdp5_kms->state" (i.e, the old/existing state) is
  replaced with mdp5_get_existing_global_state(). In the atomic_check
  path, this should be called with the glob_state_lock drm_modeset_lock
  alredy taken.
- References to "mdp5_get_state()" are replaced with
  mdp5_get_global_state(). This acquires glob_state_lock and uses
  drm_atomic_get_private_obj_state() to create a new duplicated state.

Changes in v3:
- Acquire glob_state_lock in mdp5_smp.c
- Added to the msm atomic helper patch set
Changes in v4:
- None

Signed-off-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>

...

This commit is contained in:

Archit Taneja 2018-02-21 09:37:23 -05:00 • committed by Rob Clark

parent 8d58ef346f

commit 7907a0d77c

4 changed files with 37 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c

View file

12

drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c

View file

20

drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c

View file

17

drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c

View file