bcachefs: Kill bch2_btree_iter_set_pos_same_leaf()

Browse source

The only reason we were keeping this around was for
BTREE_INSERT_NOUNLOCK semantics - if bch2_btree_iter_set_pos() advances
to the next leaf node, it'll drop the lock on the node that we just
inserted to.

But we don't rely on BTREE_INSERT_NOUNLOCK semantics for the extents
btree, just the inodes btree, and if we do need it for the extents btree
in the future we can do it more cleanly by cloning the iterator - this
lets us delete some special cases in the btree iterator code, which is
complicated enough as it is.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2021-02-07 20:16:21 -05:00 • committed by Kent Overstreet

parent 2b2c1a89ce

commit 792e2c4c85

3 changed files with 3 additions and 43 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

37

fs/bcachefs/btree_iter.c

View file

1

fs/bcachefs/btree_iter.h

View file

8

fs/bcachefs/btree_update_leaf.c

View file