iio: dac: ad5686: refactor command/data macros

Browse source

Replace usage of bit shifting macros for FIELD_PREP(), which would not
ignore bit masking when preparing SPI/I2C commands. This change is a code
hardening measure to be paired with the upcoming triggered buffer support.
For the AD5310 regmap case, 16-bit data coming from the buffer may overlap
with command bits if the data field is unmasked.

*_REF_BIT_MSK and *_PD_MSK bit position macros are renamed (with a DATA
prefix) so to indicate that they are relative to the DATA field.

Reported-by: sashiko-bot@kernel.org
Closes: https://lore.kernel.org/all/20260628143026.EC6CA1F000E9@smtp.kernel.org/
Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

...

This commit is contained in:

Rodrigo Alencar 2026-07-16 13:14:19 +01:00 • committed by Jonathan Cameron

parent 572a008526

commit 797d37e46c

4 changed files with 34 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/iio/dac/ad5686-spi.c

View file

10

drivers/iio/dac/ad5686.c

View file

22

drivers/iio/dac/ad5686.h

View file

11

drivers/iio/dac/ad5696-i2c.c

View file