xfs: fix filesystsem freeze race in xfs_trans_alloc

Browse source

As pointed out by Jan xfs_trans_alloc can race with a concurrent filesystem
freeze when it sleeps during the memory allocation.  Fix this by moving the
wait_for_freeze call after the memory allocation.  This means moving the
freeze into the low-level _xfs_trans_alloc helper, which thus grows a new
argument.  Also fix up some comments in that area while at it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <david@fromorbit.com>

...

This commit is contained in:

Christoph Hellwig 2011-07-08 14:34:42 +02:00

parent 33b8f7c247

commit 7a249cf83d

5 changed files with 27 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/xfs/xfs_fsops.c

View file

3

fs/xfs/xfs_iomap.c

View file

14

fs/xfs/xfs_mount.c

View file

27

fs/xfs/xfs_trans.c

View file

10

fs/xfs/xfs_trans.h

View file