drm/msm: Fix race of GPU init vs timestamp power management.

Browse source

We were using the same force-poweron bit in the two codepaths, so they
could race to have one of them lose GPU power early.

freedreno CI was seeing intermittent errors like:
[drm:_a6xx_gmu_set_oob] *ERROR* Timeout waiting for GMU OOB set GPU_SET: 0x0
and this issue could have contributed to it.

Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: 4b565ca5a2 ("drm/msm: Add A6XX device support")
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

...

This commit is contained in:

Eric Anholt 2021-01-28 13:03:30 -08:00 • committed by Rob Clark

parent 68e4f01fdd

commit 7a7cbf2a81

3 changed files with 32 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

drivers/gpu/drm/msm/adreno/a6xx_gmu.c

View file

8

drivers/gpu/drm/msm/adreno/a6xx_gmu.h

View file

4

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

View file