[media] v4l2-ctrls: fix sparse warning

Browse source

The warning is simple:

drivers/media/v4l2-core/v4l2-ctrls.c:1685:15: warning: incorrect type in assignment (different address spaces)

but the fix isn't.

The core problem was that the conversion from user to kernelspace was
done at too low a level and that needed to be moved up. That made it possible
to drop pointers to v4l2_ext_control from set_ctrl and validate_new and
clean up this sparse warning because those functions now always operate
on kernelspace pointers.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

...

This commit is contained in:

Hans Verkuil 2014-09-22 11:08:55 -03:00 • committed by Mauro Carvalho Chehab

parent f9cc70bfa4

commit 7a7f1ab37d

1 changed files with 52 additions and 35 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

87

drivers/media/v4l2-core/v4l2-ctrls.c

View file