HID: intel-ish-hid: Hide members of struct ishtp_cl_device

Browse source

ISH clients don't need to access any field of struct ishtp_cl_device. To
avoid this create an interface functions instead where it is required.
In the case of ishtp_cl_allocate(), modify the parameters so that the
clients don't have to dereference.
Clients can also use tracing, here a new interface is added to get the
common trace function pointer, instead of direct call.
The new interface functions defined in one external header file, named
intel-ish-client-if.h. This is the only header files all ISHTP clients
must include.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

...

This commit is contained in:

Srinivas Pandruvada 2019-03-18 12:14:20 -07:00 • committed by Jiri Kosina

parent 6b3f75f75f

commit 7ab2184246

7 changed files with 84 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

56

drivers/hid/intel-ish-hid/ishtp-hid-client.c

View file

4

drivers/hid/intel-ish-hid/ishtp-hid.c

View file

2

drivers/hid/intel-ish-hid/ishtp-hid.h

View file

27

drivers/hid/intel-ish-hid/ishtp/bus.c

View file

4

drivers/hid/intel-ish-hid/ishtp/client.c

View file

2

drivers/hid/intel-ish-hid/ishtp/client.h

View file

18

include/linux/intel-ish-client-if.h

View file