greybus: core: avoid I/O to disconnected interfaces

Browse source

Add new helper to disable connections to interfaces that have already
been disconnected (e.g. forcibly removed).

The connection tear-down procedure differs enough depending on whether
the interface is still present or already gone to warrant a dedicated
helper. This will become more obvious with the new tear-down procedure,
which involves I/O on the connection being tore down.

This also simplifies handling of the legacy bootrom, which does not
support the new tear-down operations.

Specifically, this allows us to remove the early control-connection
tear down during interface disable, and also avoids some error messages
currently printed during legacy mode switch (i.e. bootrom
boot-over-UniPro) and forcible removal.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

...

This commit is contained in:

Johan Hovold 2016-05-27 17:26:22 +02:00 • committed by Greg Kroah-Hartman

parent 898d75f4aa

commit 7aefe7918f

5 changed files with 27 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/staging/greybus/connection.c

View file

1

drivers/staging/greybus/connection.h

View file

5

drivers/staging/greybus/control.c

View file

2

drivers/staging/greybus/core.c

View file

7

drivers/staging/greybus/interface.c

View file