svc: don't hold reference for poolstats, only mutex.

Browse source

A future patch will remove refcounting on svc_serv as it is of little
use.
It is currently used to keep the svc around while the pool_stats file is
open.
Change this to get the pointer, protected by the mutex, only in
seq_start, and the release the mutex in seq_stop.
This means that if the nfsd server is stopped and restarted while the
pool_stats file it open, then some pool stats info could be from the
first instance and some from the second.  This might appear odd, but is
unlikely to be a problem in practice.

Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

...

This commit is contained in:

NeilBrown 2023-12-15 11:56:32 +11:00 • committed by Chuck Lever

parent 05a4b58301

commit 7b207ccd98

5 changed files with 36 additions and 34 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

fs/nfsd/netns.h

View file

2

fs/nfsd/nfsctl.c

View file

24

fs/nfsd/nfssvc.c

View file

8

include/linux/sunrpc/svc.h

View file

32

net/sunrpc/svc_xprt.c

View file