groups: Consolidate the setgroups permission checks

Browse source

commit 7ff4d90b4c upstream.

Today there are 3 instances of setgroups and due to an oversight their
permission checking has diverged.  Add a common function so that
they may all share the same permission checking code.

This corrects the current oversight in the current permission checks
and adds a helper to avoid this in the future.

A user namespace security fix will update this new helper, shortly.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

...

This commit is contained in:

Eric W. Biederman 2014-12-05 17:19:27 -06:00 • committed by Luis Henriques

parent 9a264c1498

commit 7b46d23fa9

4 changed files with 11 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/s390/kernel/compat_linux.c

View file

1

include/linux/cred.h

View file

9

kernel/groups.c

View file

2

kernel/uid16.c

View file