staging: rtl8188eu: move static array from .h to .c

Browse source

Declaring a static array in a header file is likely to cause name conflicts
if the declaration is pulled in multiple times.

The rtl8188 driver protects the declaration of the wlancmds array in
rtw_mlme_ext.h with ifdef _RTW_CMD_C_, which is defined only in rtw_cmd.c.
It makes more sense to declare the array in the .c file.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210408195601.4762-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Martin Kaiser 2021-04-08 21:55:56 +02:00 • committed by Greg Kroah-Hartman

parent 2fa087e0ae

commit 7b697f098d

2 changed files with 18 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

drivers/staging/rtl8188eu/core/rtw_cmd.c

View file

22

drivers/staging/rtl8188eu/include/rtw_mlme_ext.h

View file