[ARM] omap: fix inappropriate casting in gpio.c

Browse source

gpio.c wilfully casts physical addresses to void __iomem * and then
fixes them up at runtime using:

	bank->base = IO_ADDRESS(bank->base);

where accesses prior to this fixup are via omap_read/omap_write, and
after are by __raw_read/__raw_write.  This doesn't lend itself to
static checking, nor to easy understanding of the code.

And so, OMAP_MPUIO_BASE gets to be the right type - integer like since
it's a physical address, not a MMIO pointer.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

...

This commit is contained in:

Russell King 2008-09-05 15:49:14 +01:00 • committed by Russell King

parent 397fcaf717

commit 7c7095aa42

2 changed files with 36 additions and 36 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

70

arch/arm/plat-omap/gpio.c

View file

2

arch/arm/plat-omap/include/mach/gpio.h

View file