net: dsa: qca8k: check return value of read functions correctly

Browse source

Current return type of qca8k_mii_read32() and qca8k_read() are
unsigned, it can't be negative, so the return value check is
unuseful. For check the return value correctly, change return
type of the read functions and add a output parameter to store
the read value.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Yang Yingliang 2021-05-29 11:04:38 +08:00 • committed by Jakub Kicinski

parent 320daffdf2

commit 7c9896e378

1 changed files with 60 additions and 70 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

130

drivers/net/dsa/qca8k.c

View file