net: mvpp2: debugfs: Store debugfs entries data in mvpp2 struct

Browse source

The current way to store the required private data needed to access
various debugfs entries is to alloc them on the fly, share them within
the entries that need to access them, and finally have one entry free
that data upon closing. This leads to hard to maintain code, and is very
error-prone.

This commit stores all debugfs related data in the same place, making
sure this is allocated only when the debugfs directory is successfully
created, so that we don't waste memory when we don't use this feature.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Maxime Chevallier 2019-03-27 09:44:11 +01:00 • committed by David S. Miller

parent 0b27f8650f

commit 7cb5e36859

2 changed files with 26 additions and 72 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/ethernet/marvell/mvpp2/mvpp2.h

View file

94

drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c

View file