drm/amdgpu/mst: Stop ignoring error codes and deadlocking

Browse source

It appears that amdgpu makes the mistake of completely ignoring the return
values from the DP MST helpers, and instead just returns a simple
true/false. In this case, it seems to have come back to bite us because as
a result of simply returning false from
compute_mst_dsc_configs_for_state(), amdgpu had no way of telling when a
deadlock happened from these helpers. This could definitely result in some
kernel splats.

V2:
* Address Wayne's comments (fix another bunch of spots where we weren't
  passing down return codes)

Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: 8c20a1ed9b ("drm/amd/display: MST DSC compute fair share")
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Lyude Paul 2022-11-14 17:17:52 -05:00 • committed by Alex Deucher

parent c6023d73a3

commit 7cce4cd628

3 changed files with 147 additions and 118 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

View file

235

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

View file

12

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h

View file