cgroup: avoid accessing modular cgroup subsys structure without locking

Browse source

subsys[i] is set to NULL in cgroup_unload_subsys() at modular unload,
and that's protected by cgroup_mutex, and then the memory *subsys[i]
resides will be freed.

So this is unsafe without any locking:

  if (!ss || ss->module)
  ...

v2:
- add a comment for enum cgroup_subsys_id
- simplify the comment in cgroup_exit()

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

...

This commit is contained in:

Li Zefan 2013-03-05 10:57:03 +08:00 • committed by Tejun Heo

parent f50daa704f

commit 7d8e0bf56a

2 changed files with 28 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

include/linux/cgroup.h

View file

28

kernel/cgroup.c

View file