tcp: annotate tp->copied_seq lockless reads

Browse source

There are few places where we fetch tp->copied_seq while
this field can change from IRQ or other cpu.

We need to add READ_ONCE() annotations, and also make
sure write sides use corresponding WRITE_ONCE() to avoid
store-tearing.

Note that tcp_inq_hint() was already using READ_ONCE(tp->copied_seq)

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Eric Dumazet 2019-10-10 20:17:40 -07:00 • committed by David S. Miller

parent dba7d9b8c7

commit 7db48e9839

7 changed files with 19 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

net/ipv4/tcp.c

View file

3

net/ipv4/tcp_diag.c

View file

6

net/ipv4/tcp_input.c

View file

2

net/ipv4/tcp_ipv4.c

View file

2

net/ipv4/tcp_minisocks.c

View file

2

net/ipv4/tcp_output.c

View file

2

net/ipv6/tcp_ipv6.c

View file