IB/ehca: handle negative return value from ibmebus_request_irq() properly

Browse source

ehca_create_eq() was assigning a signed return value to an unsiged
local variable and then checking if the variable was < 0, which meant
that errors were always ignored.  Fix this by using one variable for
signed integer return values and another for u64 hcall return values.

Bug originally found by Roel Kluin <12o3l@tiscali.nl>.

Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

...

This commit is contained in:

Hoang-Nam Nguyen 2008-04-29 13:46:52 -07:00 • committed by Roland Dreier

parent f8b0dfd152

commit 7df109d917

1 changed files with 17 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

drivers/infiniband/hw/ehca/ehca_eq.c

View file