ice: avoid undefined behavior

Browse source

When writing the driver's struct ice_tlan_ctx structure, do not write the
8-bit element int_q_state with the associated internal-to-hardware field
which is 122-bits, otherwise the helper function ice_write_byte() will use
undefined behavior when setting the mask used for that write.  This should
not cause any functional change and will avoid use of undefined behavior.
Also, update a comment to highlight this structure element is not written.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

...

This commit is contained in:

Bruce Allan 2020-05-15 17:42:18 -07:00 • committed by Jeff Kirsher

parent ae15e0ba1b

commit 7e34786a74

4 changed files with 16 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/ethernet/intel/ice/ice_base.c

View file

12

drivers/net/ethernet/intel/ice/ice_common.c

View file

3

drivers/net/ethernet/intel/ice/ice_common.h

View file

2

drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h

View file