Merge patch series "vfs: require filesystems to explicitly opt-in to lease support"

Jeff Layton <jlayton@kernel.org> says: Yesterday, I sent patches to fix how directory delegation support is handled on filesystems where the should be disabled [1]. That set is appropriate for v6.19. For v7.0, I want to make lease support be more opt-in, rather than opt-out: For historical reasons, when ->setlease() file_operation is set to NULL, the default is to use the kernel-internal lease implementation. This means that if you want to disable them, you need to explicitly set the ->setlease() file_operation to simple_nosetlease() or the equivalent. This has caused a number of problems over the years as some filesystems have inadvertantly allowed leases to be acquired simply by having left it set to NULL. It would be better if filesystems had to opt-in to lease support, particularly with the advent of directory delegations. This series has sets the ->setlease() operation in a pile of existing local filesystems to generic_setlease() and then changes kernel_setlease() to return -EINVAL when the setlease() operation is not set. With this change, new filesystems will need to explicitly set the ->setlease() operations in order to provide lease and delegation support. I mainly focused on filesystems that are NFS exportable, since NFS and SMB are the main users of file leases, and they tend to end up exporting the same filesystem types. Let me know if I've missed any. [1]: https://lore.kernel.org/linux-fsdevel/20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org/ * patches from https://patch.msgid.link/20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org: (24 commits) fs: remove simple_nosetlease() filelock: default to returning -EINVAL when ->setlease operation is NULL xfs: add setlease file operation ufs: add setlease file operation udf: add setlease file operation tmpfs: add setlease file operation squashfs: add setlease file operation overlayfs: add setlease file operation orangefs: add setlease file operation ocfs2: add setlease file operation ntfs3: add setlease file operation nilfs2: add setlease file operation jfs: add setlease file operation jffs2: add setlease file operation gfs2: add a setlease file operation fat: add setlease file operation f2fs: add setlease file operation exfat: add setlease file operation ext4: add setlease file operation ext2: add setlease file operation ... Link: https://patch.msgid.link/20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org Signed-off-by: Christian Brauner <brauner@kernel.org>
2026-11-10 20:48:12 +00:00 · 2026-01-12 10:55:54 +01:00 · 2026-01-12 10:55:54 +01:00 · 7e463614c9
commit 7e463614c9
parent 7d42f2b1cc 51e49111c0
61 changed files with 116 additions and 42 deletions
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
--- a/Documentation/filesystems/vfs.rst
+++ b/Documentation/filesystems/vfs.rst
--- a/fs/9p/vfs_dir.c
+++ b/fs/9p/vfs_dir.c
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
--- a/fs/affs/dir.c
+++ b/fs/affs/dir.c
--- a/fs/affs/file.c
+++ b/fs/affs/file.c
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
--- a/fs/efs/dir.c
+++ b/fs/efs/dir.c
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
--- a/fs/erofs/dir.c
+++ b/fs/erofs/dir.c
--- a/fs/exfat/dir.c
+++ b/fs/exfat/dir.c
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
--- a/fs/ext2/dir.c
+++ b/fs/ext2/dir.c
--- a/fs/ext2/file.c
+++ b/fs/ext2/file.c
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
--- a/fs/freevxfs/vxfs_lookup.c
+++ b/fs/freevxfs/vxfs_lookup.c
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
--- a/fs/isofs/dir.c
+++ b/fs/isofs/dir.c
--- a/fs/jffs2/dir.c
+++ b/fs/jffs2/dir.c
--- a/fs/jffs2/file.c
+++ b/fs/jffs2/file.c
--- a/fs/jfs/file.c
+++ b/fs/jfs/file.c
--- a/fs/jfs/namei.c
+++ b/fs/jfs/namei.c
--- a/fs/libfs.c
+++ b/fs/libfs.c
--- a/fs/locks.c
+++ b/fs/locks.c
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
--- a/fs/nilfs2/dir.c
+++ b/fs/nilfs2/dir.c
--- a/fs/nilfs2/file.c
+++ b/fs/nilfs2/file.c
--- a/fs/ntfs3/dir.c
+++ b/fs/ntfs3/dir.c
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
--- a/fs/orangefs/dir.c
+++ b/fs/orangefs/dir.c
--- a/fs/orangefs/file.c
+++ b/fs/orangefs/file.c
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
--- a/fs/overlayfs/readdir.c
+++ b/fs/overlayfs/readdir.c
--- a/fs/qnx4/dir.c
+++ b/fs/qnx4/dir.c
--- a/fs/qnx6/dir.c
+++ b/fs/qnx6/dir.c
--- a/fs/read_write.c
+++ b/fs/read_write.c
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
--- a/fs/squashfs/dir.c
+++ b/fs/squashfs/dir.c
--- a/fs/squashfs/file.c
+++ b/fs/squashfs/file.c
--- a/fs/udf/dir.c
+++ b/fs/udf/dir.c
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
--- a/fs/ufs/dir.c
+++ b/fs/ufs/dir.c
--- a/fs/ufs/file.c
+++ b/fs/ufs/file.c
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
--- a/fs/vboxsf/file.c
+++ b/fs/vboxsf/file.c
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
--- a/mm/shmem.c
+++ b/mm/shmem.c