sfc: Fix maximum number of TSO segments and minimum TX queue size

Browse source

Currently an skb requiring TSO may not fit within a minimum-size TX
queue.  The TX queue selected for the skb may stall and trigger the TX
watchdog repeatedly (since the problem skb will be retried after the
TX reset).  This issue is designated as CVE-2012-3412.

Set the maximum number of TSO segments for our devices to 100.  This
should make no difference to behaviour unless the actual MSS is less
than about 700.  Increase the minimum TX queue size accordingly to
allow for 2 worst-case skbs, so that there will definitely be space
to add an skb after we wake a queue.

To avoid invalidating existing configurations, change
efx_ethtool_set_ringparam() to fix up values that are too small rather
than returning -EINVAL.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Ben Hutchings 2012-07-30 15:57:44 +00:00 • committed by David S. Miller

parent 30b678d844

commit 7e6d06f0de

4 changed files with 46 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/sfc/efx.c

View file

14

drivers/net/ethernet/sfc/efx.h

View file

16

drivers/net/ethernet/sfc/ethtool.c

View file

19

drivers/net/ethernet/sfc/tx.c

View file